guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34592: [PATCH] gnu: python-fenics-dijitso: Fix build.


From: Ricardo Wurmus
Subject: bug#34592: [PATCH] gnu: python-fenics-dijitso: Fix build.
Date: Wed, 20 Feb 2019 21:40:08 +0100
User-agent: mu4e 1.0; emacs 26.1

Paul Garlick <address@hidden> writes:

> * gnu/packages/simulation.scm (python-fenics-dijitso)[arguments]: Skip
> parallel tests.
> ---
>  gnu/packages/simulation.scm | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/gnu/packages/simulation.scm b/gnu/packages/simulation.scm
> index 20b62f3..3637cc3 100644
> --- a/gnu/packages/simulation.scm
> +++ b/gnu/packages/simulation.scm
> @@ -268,6 +268,11 @@ problems for efficient solution on parallel systems.")
>               (setenv "PYTHONPATH"
>                       (string-append (getcwd) ":" (getenv "PYTHONPATH")))
>               (with-directory-excursion "test"
> +               ;; Disable parallel tests to avoid race condition.  See
> +               ;; https://github.com/pytest-dev/pytest-cov/issues/237.
> +               (substitute* "runtests.sh"
> +                 (("for p in 1 4 8 16; do")
> +                  "for p in 1; do"))
>                 (invoke "./runtests.sh"))
>               #t)))))
>      (home-page "https://bitbucket.org/fenics-project/dijitso/";)

I wondered if we could use the #:parallel-tests? argument instead, but
the python-build-system does not support it.  This approach looks fine
to me.

Thanks!

I pushed it to the master branch with commit 7a82074ca6.

--
Ricardo






reply via email to

[Prev in Thread] Current Thread [Next in Thread]