[bug#34728] [PATCH] Update Wireshark to 3.0.0

[Ludovic Courtès]

Hi Nicolas,

Nicolas Goaziou <address@hidden> skribis:

> Ludovic Courtès <address@hidden> writes:
>
>> Nicolas Goaziou <address@hidden> skribis:
>>
>>> +       ;; "CMakeLists.txt" uses $ORIGIN, which seems to confuse
>>> +       ;; `validate-runpath' phase.
>>> +       ;;
>>> +       ;; Errors are like the following:
>>> +       ;; 
>>> "/gnu/store/...wireshark-3.0.0/lib/wireshark/plugins/3.0/epan/ethercat.so:
>>> +       ;; error: depends on 'libwireshark.so.12', which cannot be found in
>>> +       ;; RUNPATH".  That is, "/gnu/store/...wireshark-3.0.0./lib" doesn't
>>> +       ;; seem to belong to RUNPATH.
>>
>> What’s the RUNPATH on ethercat.so?
>>
>>   readelf -a ethercat.so | grep RUNPATH
>
>  0x000000000000001d (RUNPATH)            Bibliothèque 
> runpath:[:/gnu/store/...-glibc-2.28/lib:/gnu/store/...-gcc-5.5.0-lib/lib:/gnu/store/...-glib-2.56.3/lib:/gnu/store/...-libpcap-1.9.0/lib:/gnu/store/...-libgcrypt-1.8.3/lib:/gnu/store/...-libgpg-error-1.32/lib:/gnu/store/...-gnutls-3.6.5/lib:/gnu/store/...-gcc-5.5.0-lib/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/../../..]

Look, there’s no $ORIGIN in there!  :-)

So the problem is really that /gnu/store/…-wireshark-3.0.0/lib is
missing.

That’s not a problem in practice because ethercat.so is a plugin, so
it’s dlopen’d by a process that already provides libwireshark.  (It’s
still bad style IMO.)

Anyway you can keep #:validate-runpath? #f and adjust the comment.

Thank you,
Ludo’.