[bug#34882] [PATCH] Update to Pandas, enable Excel writer support

[Maxim Cournoyer]

Hello Ricardo,

Ricardo Wurmus <address@hidden> writes:

> Maxim Cournoyer <address@hidden> writes:
>
>> From ad1f0efe4a5c3d28ee9d7e2e5da275721af9e172 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <address@hidden>
>> Date: Sat, 9 Feb 2019 00:25:51 -0500
>> Subject: [PATCH 5/5] gnu: python-pandas: Update to 0.24.2.
>>
>> * gnu/packages/python-xyz.scm (python-pandas): Update to 0.24.2.
>> [phases]{patch-which}: Add phase.
>> [inputs]: Add WHICH.
>
> I have no objections to updating Pandas, but please make sure that this
> version of Pandas works well with the other scientific Python packages
> like numpy, scipy, sklearn, numba, etc.
>
> These packages usually have rather strict interdependencies and need to
> be updated together to avoid breakage.

I've already went ahead and merged those changes,  but retested the
following (on master) to make sure:

--8<---------------cut here---------------start------------->8---
for o in $(./pre-inst-env guix refresh -l python-pandas | cut -d':' -f2); do 
./pre-inst-env guix build --check --no-grafts "$o" && echo "$o OK" >> 
build.results || echo "$o NOK" >>  build.results; done
--8<---------------cut here---------------end--------------->8---

And then:
--8<---------------cut here---------------start------------->8---
$ cat build.results
address@hidden OK
address@hidden NOK
address@hidden NOK
address@hidden NOK
address@hidden NOK
address@hidden NOK
address@hidden OK
address@hidden OK
address@hidden OK
address@hidden OK
address@hidden OK
address@hidden OK
address@hidden OK
--8<---------------cut here---------------end--------------->8---

So nanopolish, deeptools, python-feather-format, python-biom-format, and
pigx are currently broken, but...

When using master on commit g8c72f13fd4
# (and re-running the same script as earlier)

--8<---------------cut here---------------start------------->8---
cat build.results.g8c72f13fd4 
address@hidden OK
address@hidden NOK
address@hidden NOK
address@hidden NOK
address@hidden NOK
address@hidden NOK
address@hidden OK
address@hidden OK
address@hidden NOK
address@hidden OK
address@hidden OK
address@hidden OK
address@hidden OK
--8<---------------cut here---------------end--------------->8---

they already were!

I've also found out while testing that Pandas was not reproducible (this
was true also before my changes).

I will create tickets for all of these problems.

Apart from that, I have run some script which uses Pandas successfully
(and the Pandas test suite passes).

Are these verifications sufficient? And why does 'guix refresh -l' seem
to miss some packages which depend on python-pandas, e.g. python-seaborn?

Thanks,

Maxim