[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#35652: [PATCH] services: dhcp-client: Ignore non-ARP network interfa
|
From: |
Marius Bakke |
|
Subject: |
bug#35652: [PATCH] services: dhcp-client: Ignore non-ARP network interfaces. |
|
Date: |
Thu, 09 May 2019 20:12:54 +0200 |
|
User-agent: |
Notmuch/0.28.3 (https://notmuchmail.org) Emacs/26.2 (x86_64-pc-linux-gnu) |
Ludovic Courtès <address@hidden> writes:
> Hi Marius,
>
> Good catch!
>
> Marius Bakke <address@hidden> skribis:
>
>> From 7724f24443392fdfc2c075909d9b64350f6578b2 Mon Sep 17 00:00:00 2001
>> From: Marius Bakke <address@hidden>
>> Date: Thu, 9 May 2019 17:03:03 +0200
>> Subject: [PATCH] services: dhcp-client: Ignore interfaces that are not ARP
>> capable.
>>
>> * guix/build/syscalls.scm (IFF_NOARP): New variable.
>> (arp-network-interface?): New public variable.
>> * gnu/services/networking.scm (dhcp-client-service-type): Filter interfaces
>> that do not support the ARP protocol.
>
> Could you make it two patches (one for syscalls.scm, and another one for
> the rest)?
>
> Otherwise LGTM, thank you!
Thanks for the amazingly fast review :-)
Pushed in a0dc97a5..6c2180f5.
signature.asc
Description: PGP signature