On Wed, May 29, 2019 at 2:10 PM Ludovic Courtès <
address@hidden> wrote:
Hello,
address@hidden skribis:
> From: Andy Tai <address@hidden>
>
> * gnu/packages/gnome.scm (terminator): Add at 1.91
[...]
> + (arguments
> + `(#:python ,python-2))
Python 2.x is reaching EOL real soon. Can it run on Python 3?
hi, no, not the current upstream... I tried with python-3 and won't run
> + (description
> + "A tool to allow running multiple GNOME terminals in a grid and
> + tabs and support for drag and drop re-ordering of terminals")
Could you make a full sentence and remove the trailing spaces? See
<https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.
will update
> + (license license:gpl2)))
This means “version 2 only”. Is there an explicit “version 2 only”
statement, for example in source file headers? If not, it should be
‘gpl2+’.
source clearly labeled gpl "Version 2 Only"
Could you send an updated patch?
will do
Thank you,
Ludo’.