guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#37038] Amending author email


From: John Soo
Subject: [bug#37038] Amending author email
Date: Wed, 28 Aug 2019 05:11:30 +0000

Hey everyone,

Sorry for that last response, stupid email client. Redoing that.  I would love to use gnus for email but I think I need to work on a more recent commit. Sorry for any formatting issues in my emails for now.

> Applied with a followup commit to address ‘guix lint’ warnings.

Thank you! I was unsure what to do about those lint errors. I updated cedille with the proper fetch to fix the lint issues with it.

>  Also, it fails to build for me

I included a second patch to fix the build issue. It looks like this line in the Makefile would cause this problem

./ial/ial.agda-lib:
    git submodule update --init --recursive

> To aid readability, I’d call the variable just ’lisp’; long names aren’t
> helpful for local variables IMO.

Fixed, I agree.

> Should it be a FIXME?

I made it a FIXME.

> ‘string-append’ is unnecessary.

Fixed, woops!.

> M-q here if you use Emacs.  :-)

I am an Emacs user but I do not know what M-q does (evil mode user, here). What does it do?

Thanks again!

- John




Attachment: 0001-gnu-agda-ial-Fix-install-step.patch
Description: Text Data

Attachment: 0002-gnu-Add-cedille.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]