[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#36467] [PATCH v2] gnu: Add some Common Lisp libraries
From: |
Pierre Neidhardt |
Subject: |
[bug#36467] [PATCH v2] gnu: Add some Common Lisp libraries |
Date: |
Mon, 16 Sep 2019 10:55:48 +0200 |
Hi Guillaume,
thanks for the big patchset, looking very good overall!
A few general nits:
- You didn't define any "ecl-" package. Could you define them for all the
packages (unless they are known to be broken with ECL)?
I know some packages lack the ecl- definition, this should be fixed :p
- 6 commit messages lack a period on the first line.
If you use Emacs, you might find this yasnippet useful:
guix/etc/snippets/text-mode/guix-commit-message-add-package
fprog:
- Description should start with a capital, or here maybe with @code{fprog}.
cambl:
- is spelled in all-caps ("CAMBL") according to the README.
cl-containers:
- synopsis: "Container library ..."
- I'm realizing the sbcl-lift does not have the right version number, which
should be (git-version "1.7.1" ...). Can you update this?
bst:
- 1.1 is out ;)
cl-octet-streams:
- Description should start with a capital, or here maybe with
@code{cl-octet-streams}.
cl-lzlib
- License seems to be GPL-3, not GPL-3+, but since this is your library, the
decision is all yours ;)
Thanks a lot for this great contribution to "Common Lisp on Guix" :)
--
Pierre Neidhardt
https://ambrevar.xyz/
signature.asc
Description: PGP signature
- [bug#36467] [PATCH v2] gnu: Add some Common Lisp libraries, Ludovic Courtès, 2019/09/04
- [bug#36467] [PATCH v2] gnu: Add some Common Lisp libraries,
Pierre Neidhardt <=
- [bug#36467] [PATCH v3] gnu: Add some Common Lisp libraries, Guillaume Le Vaillant, 2019/09/16
- [bug#36467] [PATCH v3] gnu: Add some Common Lisp libraries, Ludovic Courtès, 2019/09/16
- [bug#36467] [PATCH v3] gnu: Add some Common Lisp libraries, Pierre Neidhardt, 2019/09/16
- [bug#36467] [PATCH v3] gnu: Add some Common Lisp libraries, Katherine Cox-Buday, 2019/09/17
- [bug#36467] [PATCH v3] gnu: Add some Common Lisp libraries, Pierre Neidhardt, 2019/09/17
- [bug#36467] [PATCH v3] gnu: Add some Common Lisp libraries, Pierre Neidhardt, 2019/09/18