[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#37465] add xftwidth displayed textwidth calculator package
From: |
Kyle Andrews |
Subject: |
[bug#37465] add xftwidth displayed textwidth calculator package |
Date: |
Sun, 29 Sep 2019 10:24:32 -0400 |
Hi Ludo,
On Wed, 2019-09-25 at 15:32 +0200, Ludovic Courtès wrote:
> Hello Kyle,
>
> Kyle Andrews <address@hidden> skribis:
>
> > From 60deaa526b4a6ca5a66f3b67ba77aa353409d542 Mon Sep 17 00:00:00
> > 2001
> > From: Kyle Andrews <address@hidden>
> > Date: Thu, 19 Sep 2019 20:16:28 -0400
> > Subject: [PATCH] gnu: Add xftwidth.
> >
> > * gnu/packages/wm.scm: added xftwidth package.
>
> I think this should rather go to xdisorg.scm, WDYT?
That makes sense to me. I have added fontutils as an additional module
dependency in xdisorg.scm to satisfy the inputs.
> > + (build-system gnu-build-system)
> > + (inputs `(("freetype" ,freetype)
> > + ("libx11" ,libx11)
> > + ("fontconfig" ,fontconfig)
> > + ("libxft" ,libxft)))
>
> Nitpicking: we don’t usually align input tuples like that. :-)
>
Okay. I've removed the alignment. However, note that the dzen package
in xdisorg.scm uses this same aligned format for it's inputs.
> > + (synopsis "Calculator for determining displayed text widths
> > using Xft fonts.")
> > + (description "A small C program to calculate pixel widths for
> > displayed
> > +text using Xft fonts (given a specific font name and size). It is
> > ideal for
> > +scripts including text into the custom (e.g. dzen and xmobar
> > based) panels
> > +often used in conjunction with minimalistic window managers.")
>
> Could you address the warnings reported by ‘guix lint’ here? Also,
> make
> sure to write full sentences in the description:
>
> https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.
> html
> The rest LGTM! Could you send an updated patch?
>
> Thanks,
> Ludo’.
I've fixed the notes I saw from guix lint:
1. https -> http for github urls
2. Removed period from synopsis
3. Rewrote the description using full sentences
Please see the attached patch.
Regards,
Kyle
0001-gnu-Add-xftwidth.patch
Description: Text Data