guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#37598] [PATCH 1/4] gnu: Add python-jinja2-time.


From: Ludovic Courtès
Subject: [bug#37598] [PATCH 1/4] gnu: Add python-jinja2-time.
Date: Mon, 14 Oct 2019 00:02:43 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hi Tanguy,

Did you have a chance to look into Mathieu’s suggestions (below)?

We’re almost there so let’s make sure we don’t forget about this patch
series!

Thanks in advance,
Ludo’.

Mathieu Othacehe <address@hidden> skribis:

> Hello Tanguy,
>
> Thanks for your patches. A few remarks (more details at
> https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html):
>
>> Subject: [PATCH 1/4] gnu: Add python-jinja2-time.
>>
>
> You need to add a commit message, compliant with ChangeLog format. You
> can find examples in commit history.
>
>> +    (description
>> +     "Jinja2 Extension for Dates and Times")
>
> Description should follow the rules dictated at
> https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html#Synopses-and-Descriptions,
> most specifically "Descriptions should take between five and ten
> lines. Use full sentences, and avoid using acronyms without first
> introducing them".
>
> Otherwise, your serie seems fine :)
>
> Thanks,
>
> Mathieu





reply via email to

[Prev in Thread] Current Thread [Next in Thread]