guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#37788] [PATCH] gnu: Add minisign.


From: Mathieu Othacehe
Subject: [bug#37788] [PATCH] gnu: Add minisign.
Date: Thu, 17 Oct 2019 17:32:58 +0200
User-agent: mu4e 1.2.0; emacs 26.3

Hello Tanguy,

> Remove new blank line at EOF.

Please pass --subject-prefix="PATCH v2" to git format-patch so that it
is easier to identify patch revisions.

> +     ; No test suite

You can put it on the same line as the one below.

> +     `(#:tests? #f))

You also did forget to add the Copyright on top.

Otherwise seems fine :). I fixed the points above and pushed it.

Mathieu





reply via email to

[Prev in Thread] Current Thread [Next in Thread]