[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#37738] [PATCH] gnu: add lxqt-connman-applet
From: |
Ludovic Courtès |
Subject: |
[bug#37738] [PATCH] gnu: add lxqt-connman-applet |
Date: |
Fri, 18 Oct 2019 23:20:26 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi,
"Reza Alizadeh Majd" <address@hidden> skribis:
>> Nice. A few comments/questions:
>>
>>> +(define-public lxqt-connman-applet
>>> + (let ((commit "3db374eebd8d851f68a50fc5d1ef5fa9478c275e")
>>> + (revision "0"))
>>
>> Why did you choose this specific commit?
>>
>> Normally we only package upstream releases (tags); we resort to commits
>> in between releases only when there’s a good reason to do that, and in
>> that cases it’s better to add a comment explaining why we did that.
>
> since the package developers didn’t release a specific version so I
> decided to choose their latest commit in `master` branch. besides that
> I had tested the applet on LXQt desktop and it works without issues.
Oh, I see (I thought there was a 0.14.1 release, but there’s no such
thing on github.com.)
>> Please write a full description:
>>
>> https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html
>
> unfortunately the original developers didn’t provide any further
> details about this package yet. so is it OK to write a description
> about this package by myself?
Yes, sure!
Thank you,
Ludo’.