guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#37704] [PATCH 9/9] gnu: Add poetry.


From: Tanguy Le Carrour
Subject: [bug#37704] [PATCH 9/9] gnu: Add poetry.
Date: Mon, 28 Oct 2019 15:39:39 +0100

Le 10/28, Mathieu Othacehe a écrit :
> > +daemon. It is the client side software which allows storing values in one 
> > or
>           ^
>           two spaces
> > +more, possibly remote, memcached servers. Search google for memcached for 
> > more
> > +information.
>
> Please remove the last sentence.

*Outch*, sorry! Copy/paste is **not** your friend! … done!


> > +     "CliKit is a group of utilities to build beautiful and testable
> > +command line interfaces.")
>
> Avoid adjectives such as beautiful. Please elaborate a bit on what are
> the features of this package.

Done!


> > +    (synopsis "MessagePack (de)serializer")
> > +    (description "MessagePack (de)serializer.")
>
> Please make full sentences for description. Elaborate on both fields.

Done!


> > +             ;; Bug in poetry 
> > https://github.com/sdispater/poetry/issues/866.
> > +             (invoke "sed" "-i" "-e" "s/from distutils.core/from 
> > setuptools/" "setup.py")
>
> This line is too long.

Neither etc/indent-code.el nor `guix lint` complained!? Fixed anyway!

I'm sending v3…

Thanks for reviewing!

-- 
Tanguy





reply via email to

[Prev in Thread] Current Thread [Next in Thread]