[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#37717] [PATCH 0/3] gnu: Add kmonad.
From: |
Marius Bakke |
Subject: |
[bug#37717] [PATCH 0/3] gnu: Add kmonad. |
Date: |
Tue, 29 Oct 2019 00:11:53 +0100 |
User-agent: |
Notmuch/0.29.1 (https://notmuchmail.org) Emacs/26.2 (x86_64-pc-linux-gnu) |
Alex Griffin <address@hidden> writes:
> On 10/18/19 1:47 PM, Marius Bakke wrote:
>> I sent some feedback on the individual patches. Can you create an
>> account on Savannah if you haven't already? Then you can push the next
>> version yourself. :-)
>>
>> Please also send a reply to this message signed by the same GPG key that
>> you will use to sign commits, and make sure to upload it to Savannah.
>
> Thanks! I've attached updated patches with the suggested changes,
> created a Savannah account, and this email should be signed with my GPG key.
Great! I have added you to the Savannah project now. \o/
Make sure to read HACKING, and enjoy your new commit superpowers. :-)
> Kmonad 0.3 was released last week, but I don't think it can be updated
> in Guix until we move to a newer Stackage.
Right. Rumor has it that a new Stackage LTS 14 branch is coming up,
perhaps you can be an early tester? ;-)
>> Should this not be provided by 'ghc-primitive'? Perhaps it is
>> expecting a different version?
>
> From what I can gather, there were a few commits upstream to add support
> for primitive 0.7 without breaking 0.6, but they forgot to make the same
> change in the test suite.
>
> https://github.com/jberryman/unagi-chan/commit/b4af3f2b0d76de701ec8ca4a17ab88f776fe80a9
OK. Can you adjust the comment to mention that a newer ghc-primitive is
required? Otherwise LGTM.
Thanks, and welcome!
signature.asc
Description: PGP signature
- [bug#37717] [PATCH 0/3] gnu: Add kmonad., Alex Griffin, 2019/10/12
- [bug#37717] [PATCH 1/3] gnu: Add ghc-atomic-primops., Alex Griffin, 2019/10/12
- [bug#37717] [PATCH 2/3] gnu: Add ghc-unagi-chan., Alex Griffin, 2019/10/12
- [bug#37717] [PATCH 3/3] gnu: Add kmonad., Alex Griffin, 2019/10/12
- [bug#37717] [PATCH 3/3] gnu: Add kmonad., Alex Griffin, 2019/10/12
- [bug#37717] [PATCH 0/3] gnu: Add kmonad., Marius Bakke, 2019/10/18