guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#37908] [PATCH 0/2] Remove monolithic qt5 (and other unused package)


From: Ludovic Courtès
Subject: [bug#37908] [PATCH 0/2] Remove monolithic qt5 (and other unused package)
Date: Fri, 01 Nov 2019 15:14:08 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hi Hartmut,

Hartmut Goebel <address@hidden> skribis:

> From: Hartmut Goebel <address@hidden>
> Date: Thu, 24 Oct 2019 20:28:26 +0200
> Subject: [Patch v2 2/2] gnu: Deprecate monolithic qt5.
>
> This package was not used anywhere but as a based for qt-4.
>
> * gnu/packages/qt.scm (qt-4): Copy all relevant package definition
>   parts from 'qt'.
>   (qt): Define as a deprecated alias for 'qtbase`.

Please ensure that “guix build qt@4 -nd” returns the same derivation
before and after the change.

> +(define-deprecated qt qtbase qtbase)

Perhaps add a comment above saying that ‘qt’ used to refer to the
monolithic Qt 5.x package?

Otherwise LGTM!  Efraim, can you say if this is fine with you?
When Efraim agrees to the change, I guess you can go ahead.

Thank you,
Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]