[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#38214] [PATCH] gnu: Add minisat.
From: |
Mathieu Othacehe |
Subject: |
[bug#38214] [PATCH] gnu: Add minisat. |
Date: |
Fri, 15 Nov 2019 16:03:35 +0100 |
User-agent: |
mu4e 1.2.0; emacs 26.3 |
Hello Robert,
Thanks for your patch, a few remarks below.
> + (search-patches "minisat-friend-declaration.patch"
> + "minisat-mroot-and-install.patch"))))
Why are these patch needed? It seems that the last release was a long
time ago, maybe we should package it from a git commit?
> + ("kernel-headers" ,linux-libre-headers)))
^
Is this really useful? It seems to build without.
> + (synopsis
> + "Small, yet efficient, SAT solver with good documentation")
> + (license license:expat)
It's a tacit agreement, but the order of package fields is often:
- synopsis
- description
- home-page
- license.
Could you re-order those fields?
Do not forget to add your copyright on top of the file, and to indent
your code properly (see:
https://guix.gnu.org/manual/en/html_node/Formatting-Code.html).
Could you send an updated patch?
Thanks,
Mathieu