[bug#38286] [PATCH] gnu: Add netcat-openbsd.

[Ludovic Courtès]

Hello!

"Alex Griffin" <address@hidden> skribis:

> From 41abd13973e20750815b5f395acb9fc4893c6817 Mon Sep 17 00:00:00 2001
> From: Alex Griffin <address@hidden>
> Date: Tue, 19 Nov 2019 19:59:32 -0600
> Subject: [PATCH] gnu: Add netcat-openbsd.
>
> * gnu/packages/admin.scm (netcat-openbsd): New variable.

Overall LGTM; I like that we’re not taking responsibility for all these
patches.  :-)

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url 
> "https://salsa.debian.org/debian/netcat-openbsd.git";)
> +                    (commit (string-append "debian/" version))))
> +              (sha256
> +               (base32
> +                "0j85gzbjzs6yrhgabh3zkwzd27qkr5s0zjjczl0hah8q7yhrjk3m"))))

I suspect ‘guix lint’ suggests a ‘file-name’ field here.  :-)

> +    (home-page "https://packages.debian.org/sid/netcat-openbsd";)
> +    (synopsis "TCP/IP swiss army knife")

Could you make that more factual, like “Read and write data over TCP/IP”
(same as for ‘netcat’ actually)?

> +    (description
> +     "A simple Unix utility which reads and writes data across network
         ^
Please write full sentences.

OK to push with changes along these lines!

Thanks,
Ludo’.