[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#38463] [PATCH 3/3] gnu: emacs-telega: Properly install alists.
From: |
Leo Prikler |
Subject: |
[bug#38463] [PATCH 3/3] gnu: emacs-telega: Properly install alists. |
Date: |
Thu, 05 Dec 2019 23:55:09 +0100 |
User-agent: |
Evolution 3.30.5 |
Am Donnerstag, den 05.12.2019, 12:46 -0600 schrieb Brett Gilio:
> That is why I made the note about eventually replacing the
> installation of that directory to use the system usually used by
> `emacs-build-system` because I figure this would cause less issues in
> the future if for some reason the emacs site-lisp directory structure
> were to change again.
>
> --8<---------------cut here---------------start------------->8---
> ;; TODO: Replace with `#:include' method used by
> ;; emacs-build-system.
> --8<---------------cut here---------------end--------------->8---
>
> But I don't think it is a pressing issue to do it so cleanly.
> Or maybe it is. Idk.
Perhaps you're right, but as far as I can see the Emacs build system
does not yet tell us how to proceed with data. It also has a unique
way of handling documentation, first putting it into site-lisp before
moving it to share/info where it should belong.
> > I still don't feel comfortable with data being at the top of site-
> > lisp,
> > though. Perhaps something similar to emacs-yasnippet-snippets,
> > where
> > you store the data in share/emacs/telega-data would be more
> > appropriate.
>
> I was ACTUALLY going to do it this way originally, but I was really
> uncertain of it so I just sent the patch as is. I like the idea more,
> so
> I am going to revise the patch. Otherwise, once I get this revision
> in
> everything should be good to go. I'll also substitute the functions
> to
> reflect that changed path.
>
> [...]
>
> Alright, carry on! Patch will be available soon.
Looking at your revised patch, I still feel a bit uneasy about putting
data into the load-path. I therefore proprose a revised revised (R^2,
if you will) patch, which I've attached to this message.
Regards,
Leo
0003-gnu-emacs-telega-Install-telega-data-to-site-lisp.patch
Description: Text Data
- [bug#38463] [PATCH] Telega test suite and change in revision, Brett Gilio, 2019/12/02
- [bug#38463] [PATCH 1/2] gnu: emacs-telega: Use test suites., Brett Gilio, 2019/12/02
- [bug#38463] [PATCH 2/2] gnu: emacs-telega: Update to 0.4.4-2, Brett Gilio, 2019/12/02
- [bug#38463] [PATCH] Telega test suite and change in revision, Brett Gilio, 2019/12/04
- [bug#38463] [PATCH 3/3] gnu: emacs-telega: Properly install alists., Brett Gilio, 2019/12/05
- [bug#38463] [PATCH 3/3] gnu: emacs-telega: Properly install alists., Leo Prikler, 2019/12/05
[bug#38463] [PATCH 3/3] gnu: emacs-telega: Install telega-data to site-lisp., Brett Gilio, 2019/12/05