[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#38460] [PATCH 1/1] lint: Add '--load-path' option.
From: |
Ludovic Courtès |
Subject: |
[bug#38460] [PATCH 1/1] lint: Add '--load-path' option. |
Date: |
Sat, 07 Dec 2019 23:51:39 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi!
zimoun <address@hidden> skribis:
> On Wed, 4 Dec 2019 at 18:10, Ludovic Courtès <address@hidden> wrote:
>
>> zimoun <address@hidden> skribis:
>>
>> > * guix/scripts/lint.scm (%options): Add '--load-path' option.
>> > * tests/guix-lint.sh: Test it.
>>
>> Awesome, I’ve been wanting that for a long time. :-)
>
> But I find this "hacky". Because it is copy/paste from other
> --load-path option elsewhere (probably "guix show" :-)).
Well, technically speaking it’s not copy/pasted since the code you sent
uses ‘find’ to grab the option; plus, we’re talking about very few
lines, which is typically hard to factorize.
So I sympathize with the bad feeling of repetition, but I’m not quite
sure how this can be avoided in this case.
WDYT?
Thanks,
Ludo’.