[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#38103] Dracula emacs theme
From: |
Brett Gilio |
Subject: |
[bug#38103] Dracula emacs theme |
Date: |
Mon, 09 Dec 2019 22:50:17 -0600 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Marius Bakke <address@hidden> writes:
> address@hidden writes:
>
>> Hi,
>>
>> Second attempt to attach the patch.
>
> Looks good!
>
> [...]
>
>> +(define-public emacs-dracula-theme
>> + (package
>> + (name "emacs-dracula-theme")
>> + (version (git-version "0" "0"
>> "320cc8cfc67e33c86045ef3e79b7627b91b9b517"))
>> + (source
>> + (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://github.com/dracula/emacs.git")
>> + (commit "320cc8cfc67e33c86045ef3e79b7627b91b9b517")))
>
> Could add a (let (commit ...)) binding for the commit hash so we don't
> have to repeat it twice? See the surrounding packages for examples.
>
> Please also add a 'file-name' field here.
>
>> + (sha256
>> + (base32
>> + "0pzlwxsa823sbcf2nq2lw303cld2jc2siaaiafld0qc4xasg9zyn"))))
>> + (build-system emacs-build-system)
>> + (home-page "https://draculatheme.com/emacs")
>> + (synopsis "A dark theme for emacs")
>
> Just "Dark theme for Emacs", to appease 'guix lint emacs-dracula-theme'.
>
>> + (description
>> + "A dark theme for emacs and 50+ apps")
>
> Can you expand a bit on the "50+ apps" part? Perhaps something along
> the lines of "Dracula is a dark color theme implemented for more than 50
> different applications. This package provides the Emacs theme."
>
> Can you send an updated patch? Thanks, and welcome! :-)
>
Hi Marius and bluekeys!
I just wanted to bump this so we can get it pushed. If you would like
some help, bluekeys please do not hesitate to ask us either here or on
the #guix Freenode IRC.
Also, when you send your revised patch do include yourself in the
copyright section of the header! You deserve that designation for your
contribution.
Thanks!
--
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#38103] Dracula emacs theme,
Brett Gilio <=