[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#38637] [PATCH 1/4] gnu: Add python-iocapture.
From: |
Ricardo Wurmus |
Subject: |
[bug#38637] [PATCH 1/4] gnu: Add python-iocapture. |
Date: |
Mon, 16 Dec 2019 17:27:50 +0100 |
User-agent: |
mu4e 1.2.0; emacs 26.3 |
Hi Mădălin,
> * gnu/packages/python-xyz.scm (python-iocapture): New variable.
thanks for the patch!
> +(define-public python-iocapture
> + ;; the latest is more than year newer than the latest realease
I know what you mean but that’s not what the comment says ;) I
changed it.
> + (let ((commit "fdc021c431d0840303908dfc3ca8769db383595c")
> + (revision "1"))
> + (package
> + (name "python-iocapture")
> + (version "0.1.2")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference (url "https://github.com/oinume/iocapture.git")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1mkbhqibxvgwg0p7slr8dfraa3g2s6bsayladhax2jccwj4kcndz"))))
> + (build-system python-build-system)
> + (propagated-inputs
> + `(("python-flexmock" ,python-flexmock)
> + ("python-pytest" ,python-pytest)
> + ("python-pytest-cov" ,python-pytest-cov)
> + ("python-six" ,python-six)))
> + (home-page "https://github.com/oinume/iocapture")
> + (synopsis "Phython capuring tool for stdout and stderr")
Typos: Phython –> Python; capuring –> capturing
> + (description
> + "python-iocapture helps you to capture the standard out (stdout) and
> the
> +standard error channel (stderr) in your program.")
> + (license license:expat)))) ; MIT license
The term “MIT license” is ambiguous, so we don’t use it, not even in a
comment.
I noticed that the tests were not actually run, so I overrode the check
phase.
I pushed this with modifications to the “master” branch with commit
dbcef44a0b.
Thanks again!
--
Ricardo