[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#38513: [PATCH] gnu: Remove uses of deprecated Qemu "-nic, model=foo"
From: |
Marius Bakke |
Subject: |
bug#38513: [PATCH] gnu: Remove uses of deprecated Qemu "-nic, model=foo" invokations. |
Date: |
Wed, 18 Dec 2019 22:12:08 +0100 |
User-agent: |
Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) |
Ludovic Courtès <address@hidden> writes:
> Hi!
>
> Marius Bakke <address@hidden> skribis:
>
>> * gnu/build/vm.scm (load-in-linux-vm): Move Qemu network configuration from
>> ARCH-SPECIFIC-FLAGS to the Qemu command line. Use the "-nic" option of Qemu
>> instead of "-device" and "-net".
>> * gnu/system/vm.scm (common-qemu-options): Change "-net nic ..." to "-nic
>> user ...".
>> * doc/guix.texi (Installing Guix in a VM, Running Guix in a VM): Adjust
>> examples accordingly.
>
> Apart from the typo Leo noted, it LGTM! :-)
I discovered a problem with our documentation when researching this
patch. Qemu nowadays, with no "-nic" or related arguments, acts the
same as "-nic,model=e1000e". So a full network is available by default,
unless one adds "-nic none".
The "Running Guix in a VM" section of the manual mentions Qemu
networking twice, and both are inaccurate or wrong. It would be good to
reword that section. Any takers? :-)
In any case this patch will be pushed shortly.
signature.asc
Description: PGP signature