guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#38662] [PATCH] gnu: Add emacs-next.


From: Ludovic Courtès
Subject: [bug#38662] [PATCH] gnu: Add emacs-next.
Date: Fri, 20 Dec 2019 22:59:56 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hi Amin,

Amin Bandali <address@hidden> skribis:

> Add `emacs-next' for building latest Emacs from git.
>
> * gnu/packages/emacs.scm (emacs-next): New variable.
> (emacs): make the autoload deletion snippet not fail when eshell/esh-groups.el
> does not exist.  This enables reuse of the entire snippet field of `emacs' for
> `emacs-next'.

Nice!  Please also mention the new patch file and add it to
gnu/local.mk.

It LGTM, but…

>               (snippet
> -              ;; Delete the bundled byte-compiled elisp files and
> -              ;; generated autoloads.
>                '(with-directory-excursion "lisp"
> +                 ;; Delete the bundled byte-compiled elisp files and 
> generated
> +                 ;; autoloads.
>                   (for-each delete-file
>                             (append (find-files "." "\\.elc$")
>                                     (find-files "." "loaddefs\\.el$")
>                                     ;; This is the only "autoloads" file that
>                                     ;; does not have "*loaddefs.el" name.
> -                                   '("eshell/esh-groups.el")))
> +                                   (find-files "." 
> "eshell/esh-groups\\.el$")))

This change causes a rebuild of ‘emacs’, ‘emacs-minimal’, and everything
that depends on them (1K+ packages.)  Can it be avoided somehow?

One solution would be to duplicate the snippet for now in ‘emacs-next’.

> --- /dev/null
> +++ b/gnu/packages/patches/emacs27-exec-path.patch

Please add a line or two at the top explaining what this patch does.

Could you send an updated patch?

Thanks!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]