guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#38742] [PATCH] gnu: python-fonttools: Update to 4.2.2


From: Danny Milosavljevic
Subject: [bug#38742] [PATCH] gnu: python-fonttools: Update to 4.2.2
Date: Thu, 26 Dec 2019 12:58:01 +0100

Hi,

thanks for the patch!  I have a few comments below:

* I can't apply it.  There's two parts in your message:
  (1) A rfc822 format file with MIME escape parts (like "=C2=A0") in it which 
"git am" cannot use and which looks very unusable.
  (2) A plain text format file (much better) which is missing the author 
information ("From"...)--so "git am" cannot use it.
  If that's a problem with our Guix-patches tooling (or my mail client), I 
apologize, but even with manual editing I could not apply (2).  (1) is out of 
the question.
  Please use "git format-patch -1" after committing the change to your local 
git repository in order to create the patch.
  You can revert your patch using "git reset HEAD~1" and then try "git am 
your-patchfile" on your side to see whether we would be able to apply it.
* Please rename the procedure from "python-fonttools-version" to 
"python-fonttools-package" for consistency with other places we do that.
* Please mention the new procedure in the commit log.
* Please put maintainer comments into the source code, not the commit log.
* A comment trailing a scheme line should have only one ";".

> +    (python-fonttools-version

python-fonttools-package

> +      "3.44.0"  ;; last version to support Python 2

+      "3.44.0"  ; last version to support Python 2

Attachment: pgptJv1fJgstd.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]