[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#38754] [PATCH 2/2] scripts: lint: Set the %link-checker-store-conne
From: |
Christopher Baines |
Subject: |
[bug#38754] [PATCH 2/2] scripts: lint: Set the %link-checker-store-connection parameter. |
Date: |
Thu, 26 Dec 2019 18:01:04 +0000 |
If set, this parameter provides a store connection used by the derivation
linter. Without this being set, the derivation linter establishes a new
connection for each package. With this change, I saw the time taken to lint
all packages with the derivation linter drop from over 4 minutes to around 3
minutes.
* guix/scripts/lint.scm (guix-lint): Set the %lint-checker-store-connection)
parameter.
---
guix/scripts/lint.scm | 22 +++++++++++++---------
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
index 8d08c484f5..47c104217d 100644
--- a/guix/scripts/lint.scm
+++ b/guix/scripts/lint.scm
@@ -28,6 +28,7 @@
(define-module (guix scripts lint)
#:use-module (guix packages)
+ #:use-module (guix store)
#:use-module (guix lint)
#:use-module (guix ui)
#:use-module (guix scripts)
@@ -167,12 +168,15 @@ run the checkers on all packages.\n"))
(_ #f))
(reverse opts)))
(checkers (or (assoc-ref opts 'checkers) %all-checkers)))
- (cond
- ((assoc-ref opts 'list?)
- (list-checkers-and-exit checkers))
- ((null? args)
- (fold-packages (lambda (p r) (run-checkers p checkers)) '()))
- (else
- (for-each (lambda (spec)
- (run-checkers (specification->package spec) checkers))
- args)))))
+ (with-store store
+ (parameterize
+ ((%lint-checker-store-connection store))
+ (cond
+ ((assoc-ref opts 'list?)
+ (list-checkers-and-exit checkers))
+ ((null? args)
+ (fold-packages (lambda (p r) (run-checkers p checkers)) '()))
+ (else
+ (for-each (lambda (spec)
+ (run-checkers (specification->package spec) checkers))
+ args)))))))
--
2.24.1
[bug#38754] [PATCH 0/2] Speed up the derivation linter., Ludovic Courtès, 2019/12/30