[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#39261] [PATCH] guix: import/crate: Move build-dependencies to cargo
From: |
Ludovic Courtès |
Subject: |
[bug#39261] [PATCH] guix: import/crate: Move build-dependencies to cargo-inputs. |
Date: |
Wed, 05 Feb 2020 00:17:36 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello!
Nitpick: for the subject line, I’d write:
import: crate: Move build dependencies to cargo-inputs.
Efraim Flashner <address@hidden> skribis:
> * guix/import/crate.scm (crate->guix-package): Add definition for
> 'dev-dependency?' and 'build-dependency?'. Adjust dep-crates to take
> normal- and build- dependencies.
[...]
> + (define (dev-dependency? dependency)
> + (eq? (crate-dependency-kind dependency) 'dev))
Nitpick2: I’d recommend ‘development-dependency?’ as per the style
guidelines. :-)
Anyhow, LGTM!
Thanks,
Ludo’.
- [bug#39261] [PATCH] guix: import/crate: Move build-dependencies to cargo-inputs.,
Ludovic Courtès <=