[bug#39698] [PATCH] file-systems: Set default value of the check? field to #f for NFS

[Maxim Cournoyer]

Hi Ludovic!

Ludovic Courtès <address@hidden> writes:

> Hi,
>
> Maxim Cournoyer <address@hidden> skribis:
>
>> --- a/gnu/system/file-systems.scm
>> +++ b/gnu/system/file-systems.scm
>> @@ -101,6 +101,8 @@
>>  (define-record-type* <file-system> %file-system
>>    make-file-system
>>    file-system?
>> +  this-file-system
>> +
>>    (device           file-system-device) ; string | <uuid> | 
>> <file-system-label>
>>    (mount-point      file-system-mount-point)      ; string
>>    (type             file-system-type)             ; string
>> @@ -113,7 +115,10 @@
>>    (needed-for-boot? %file-system-needed-for-boot? ; Boolean
>>                      (default #f))
>>    (check?           file-system-check?            ; Boolean
>> -                    (default #t))
>> +                    (thunked)
>> +                    (default (not (string-prefix-ci?
>> +                                   (file-system-type this-file-system)
>> +                                   "nfs"))))
>
> I’d rather avoid making ‘check?’ a thunked field (it adds a bit of
> overhead and breaks ‘equal?’.)
>
> Could we instead special-case NFS in (gnu build file-systems) such that
> checking is a no-op?
>
> Thanks,
> Ludo’.

This actually was the first implementation I'd done, before attempting
to go fancy with the thunked default value ;-).

You'll find it attached.

Thanks!

0001-build-file-systems-Skip-check-for-NFS-file-systems.patch
Description: Text Data

Maxim

signature.asc
Description: PGP signature