[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#40320] [PATCH 1/2] gnu: Add libqalculate
From: |
Danny Milosavljevic |
Subject: |
[bug#40320] [PATCH 1/2] gnu: Add libqalculate |
Date: |
Mon, 30 Mar 2020 12:45:39 +0200 |
Hi Veera,
thanks for the patch!
I have a few suggestions:
On Mon, 30 Mar 2020 10:52:23 +0530
R Veera Kumar <address@hidden> wrote:
> +(define-public libqalculate
> + (let ((commit "90b52e685c1b0575558c5dd449dde71c313d084a")
> + (revision "1"))
According to github[1], this seems to be the tag "v3.8.0".
> + (version (git-version "3.8.0" revision commit))
... so please just use (version "3.8.0")
> + (commit commit)
... and (commit (string-append "v" version))
> + ("automake" ,automake)
> + ("autoconf" ,autoconf)
It's unusual to need those in a release. Why are they necessary?
> + (arguments
> + `( #:phases
> + (modify-phases %standard-phases
> + (delete 'bootstrap) ;; fails in autogen.sh
> + (add-before 'configure 'autogen
Why not just (replace 'bootstrap
...
) ?
>+ (synopsis "Multi-purpose cli desktop calculator and library")
> + (description
> + "Libqalculate is a multi-purpose cli desktop calculator and library.
> +It provides basic and advanced functionality. Features include customizable
> +functions, unit calculations, and conversions, physical constants, symbolic
> +calculations (including integrals and equations), arbitrary precision,
> +uncertainity propagation, interval arithmetic, plotting and a user-friendly
> +cli.")
Maybe mention that this is the library, not the program.
[1] https://github.com/Qalculate/libqalculate/releases
pgp2PflZmy1KO.pgp
Description: OpenPGP digital signature