[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#40291] gnu: packages: java: Add libantlr3c
From: |
Maxim Cournoyer |
Subject: |
[bug#40291] gnu: packages: java: Add libantlr3c |
Date: |
Tue, 31 Mar 2020 00:53:59 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello Raghav!
You'll find my review of this patch below. For other readers, this is
needed in preparation of Linphone, which requires it through its
belle-sip dependency.
"Raghav Gururajan" <address@hidden> writes:
> Hello Guix!
>
> Please find the attached patch to add "libantlr3c" package.
>
> Regards,
> RG.
>
> From 791e2392aaa9a3202db90c1e50340c38bd001504 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <address@hidden>
> Date: Sat, 28 Mar 2020 14:21:35 -0400
> Subject: [PATCH 6/6] gnu: packages: java: Add libantlr3c
This should be: "gnu: Add libantlr3c."
> * gnu/packages/java.scm (libantlr3c): New variable.
> ---
> gnu/packages/java.scm | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 5154dc124e..400ef8795e 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -105,6 +105,35 @@
> ;; build framework. We then build the more recent JDKs Icedtea 2.x and
> ;; Icedtea 3.x.
>
> +(define-public libantlr3c
> + (package
> + (name "libantlr3c")
> + (version "3.4")
> + (source
> + (origin
> + (method url-fetch)
> + (uri
> + (string-append "https://www.antlr3.org/download/C/";
> + name "-" version ".tar.gz"))
> + (sha256
> + (base32 "0lpbnb4dq4azmsvlhp6khq1gy42kyqyjv8gww74g5lm2y6blm4fa"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:configure-flags
> + (list
> + "--enable-debuginfo"
> + "--enable-64bit"
Is this really required? The default is "no". If enabled, it probably
needs to be made conditional so that it is only enabled for 64 bits
architectures.
> + "--enable-abiflags"
> + "--enable-antlrdebug"
> + "--enable-shared"
> + "--enable-static"
If enabled, the static library should go to its own "static" output.
> + "--enable-fast-install")))
> + (synopsis "ANTLR C Library")
> + (description "LIBANTLR3C provides run-time C libraries for ANTLR3
> +(ANother Tool for Language Recognition v3).")
> + (home-page "https://www.antlr3.org/";)
> + (license license:bsd-3)))
> +
The indentation is off. If you don't use Emacs for editing, you can run
the Emacs script provided by Guix like this:
./etc/indent-code.el gnu/packages/java.scm libantlr3c
Thanks!
Maxim