[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#40264] Linphone: 11-add-mediastreamer-v2
From: |
Raghav Gururajan |
Subject: |
[bug#40264] Linphone: 11-add-mediastreamer-v2 |
Date: |
Fri, 03 Apr 2020 14:30:09 +0000 |
Hi Danny!
>> + (list
>>
>> + ;; For fixing definitions.
>
> Yes, but why? What would happen if we didn't do it?
Otherwise, we get `-Werror` flag related compilation errors.
>> + (origin
>> + (method url-fetch)
>> + (uri
>> + (string-append
>> "https://gitlab.linphone.org/BC/public/mediastreamer2/commit"
>> + "de3a24b795d7a78e78eab6b974e7ec5abf2259ac.diff"))
>> + (file-name "mediastreamer-msfactory.patch")
>
> I'm not sure what the outcome of the latest discussion on carrying patches
> was.
> Should we carry patches in Guix now or fetch them from external source?
I think it's good as long as we use hash to verify. :-)
>> + "-DENABLE_GSM=NO" ; Need recompilation with -fPIC
>
> Uhhhhhhhhh if that's a library, it should have been compiled with "-fPIC", no?
>
> Which library would need recompilation with "-fPIC"?
I am not sure about this one. Since it is a feature, I was planning on to deal
this later and disable gsm for now. I hope it is okay.
Regards,
RG.