[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#40543] [PATCH 4/4] gnu: virt-manager: Work towards enabling some te
From: |
Christopher Baines |
Subject: |
[bug#40543] [PATCH 4/4] gnu: virt-manager: Work towards enabling some tests. |
Date: |
Wed, 15 Apr 2020 18:57:31 +0100 |
User-agent: |
mu4e 1.2.0; emacs 26.3 |
Marius Bakke <address@hidden> writes:
> Christopher Baines <address@hidden> writes:
>
>> * gnu/packages/virtualization.scm (virt-manager)[arguments]: Set
>> #:test-target
>> to "test_ui", replace the 'check phase.
>> [native-inputs]: Add some inputs required for running tests.
>
> [...]
>
>> @@ -673,6 +684,11 @@ virtualization library.")
>> ("gobject-introspection" ,gobject-introspection)
>> ("gtk+" ,gtk+ "bin") ; gtk-update-icon-cache
>> ("perl" ,perl) ; pod2man
>> + ("python-dogtail" ,python-dogtail)
>> + ("xvfb" ,xorg-server)
>> + ("dbus" ,dbus)
>> + ("at-spi2-core" ,at-spi2-core)
>> + ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
>
> Please leave a comment along the lines of
>
> ;; The following are required for running the tests.
>
> ...to leave a clue for the next packager who wonders whether these
> inputs are misplaced.
>
> Apart from these comments, the series LGTM.
Sure, I've sent some new patches now with this change.
signature.asc
Description: PGP signature