|
From: | L p R n d n |
Subject: | [bug#35305] LightDM service |
Date: | Wed, 22 Apr 2020 17:26:04 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello, Here is the new set of patches with quite a few modifications for the service, everything rebased on 1.1.0. After a discussion with bricewge on irc, a new design has been adopted allowing use of multiple seats. To use the service, you can instantiate a lightdm-service-type, a lightdm-gtk-greeter-service-type or both. The service should always find a way to start a working instance of LightDM. :) A non exhaustive list of changes that might need further review: * lightdm-gtk-greeter has its own service extending lightdm-service and others. * Seats configuration use now the lightdm-seat-record-type and can be defined both in the lightdm-service and lightdm-gtk-greeter-service. The greeter now extends the LightDM's service by providing a list of seats. * The `compose` and `extend` field of the lightdm-service-type have seen work for this purpose while keeping compatibility with `set-xorg-configuration`. * extra-config fields are list of strings to avoid weird indentation in the user's config. * Fixed customization of lightdm-gtk-greeter's cursor. * Added some fields to deal with accessibility for lightdm-gtk-greeter-configuration. * Takes default background from guix-artwork. Also a review of PAM services might be nice as I'm not versed in security. However, I didn't get rid of etc-service-type's extension as LightDM's seems to ignore `sessions-directory` when configuration is passed through `--config`. Patches to fix that are welcome but can wait a future patch submission, I think. Otherwise, tested in a WM: default configurations, autologin, sway, changing greeter appearance and everything worked fine. For passwordless login, had to actually delete user's password manually to make it work. I don't know if it's expected. Have a nice day and good review :) L p R n d n
0001-gnu-lightdm-Update-1.30.0.patch
Description: Text Data
0002-gnu-lightdm-Add-vala-bindings.patch
Description: Text Data
0003-gnu-lightdm-Disable-python-tests-only.patch
Description: Text Data
0004-gnu-lightdm-gtk-greeter-Fix-at-spi-runtime-dependenc.patch
Description: Text Data
0005-gnu-lightdm-gtk-greeter-Fix-.desktop-file.patch
Description: Text Data
0006-gnu-lightdm-gtk-greeter-Wrap-binary.patch
Description: Text Data
0007-gnu-lightdm-Build-accountsservice-files.patch
Description: Text Data
0008-gnu-lightdm-gtk-greeter-Fix-some-warnings.patch
Description: Text Data
0009-services-Add-lightdm-service-type.patch
Description: Text Data
0010-gnu-lightdm-gtk-greeter-Set-XCURSOR_PATH-in-wrapper.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |