[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41671] [PATCH] gnu: Add emacs-glsl-mode
From: |
Nicolas Goaziou |
Subject: |
[bug#41671] [PATCH] gnu: Add emacs-glsl-mode |
Date: |
Tue, 02 Jun 2020 22:04:00 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
Fredrik Salomonsson <plattfot@gmail.com> writes:
> * gnu/packages/emacs-xyz.scm (emacs-glsl-mode): New variable
Thank you. Some comments follow.
Nitpick: you need full stops at the end of each sentence in the commit
message.
> + (sha256
> + (base32
> + "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s"))))
Nitpick: could you move the hash on the same line as `base32'?
> + (build-system emacs-build-system)
> + (home-page
> + "https://github.com/jimhourihan/glsl-mode")
Nitpick: could you move the URL on the same line as `home-page'?
> + (synopsis
> + "Major mode for Open GLSL shader files")
Nitpick: … guess what… ;)
> + (description
> + "Major mode for editing OpenGLSL grammar files, usually files ending
> with
> +`.vert', `.frag', `.glsl', `.geom'.
This should be a complete sentence, e.g.,
The library provides a major mode…
Note that Texinfo syntax for file extensions is @file, so the rest of
the sentence ought to be:
files ending with @file{.vert}, @file{.frag}…
> Is is based on c-mode plus some
Typo and nitpick: "It is based on C mode"
Could you send an updated patch?
Regards,
--
Nicolas Goaziou