[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41756] [PATCH] gnome: gnome-desktop: Add bubblewrap as an input.
From: |
Ludovic Courtès |
Subject: |
[bug#41756] [PATCH] gnome: gnome-desktop: Add bubblewrap as an input. |
Date: |
Tue, 09 Jun 2020 09:36:59 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi!
(There’s a typo in the subject prefix.)
Christopher Baines <mail@cbaines.net> skribis:
> This is expected to be available, oddly as libseccomp is available. These
> changes fix thumbnails for Nautilus.
>
> * gnu/packages/gnome.scm (gnome-desktop)[arguments]: Add 'patch-bubblewrap
> phase.
> [inputs]: Add bubblewrap.
Nice, I didn’t know the thumbnailer would do that.
> + (add-before 'configure 'patch-bubblewrap
> + (lambda* (#:key inputs #:allow-other-keys)
> + (substitute* "libgnome-desktop/gnome-desktop-thumbnail-script.c"
> + (("\"bwrap\",")
> + (string-append "\"" (which "bwrap") "\","))
> + (("\"--ro-bind\", \"/usr\", \"/usr\",")
> + (string-append "\"--ro-bind\", \""
> + (%store-directory)
> + "\", \""
> + (%store-directory)
> + "\","))
> + (("\"--ro-bind\", \"/etc/ld.so.cache\",
> \"/etc/ld.so.cache\",")
> + "\"--ro-bind\", \"/run/current-system\",
> \"/run/current-system\","))
Perhaps we can replace this second --ro-bind with the empty string?
Otherwise LGTM!
Ludo’.