[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41785] [PATCH] DRAFT services: Add 'hurd-in-vm service-type'.
From: |
Mathieu Othacehe |
Subject: |
[bug#41785] [PATCH] DRAFT services: Add 'hurd-in-vm service-type'. |
Date: |
Fri, 12 Jun 2020 16:42:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello Ludo & janneke,
> Mathieu, can we make ‘find-image’ non-monadic? It really shouldn’t be
> because it doesn’t interact with the store. It can take an optional
> ‘system’ parameter if we want.
Yes, you're right, passing 'target' to 'find-image' should be enough to
make it non-monadic.
> So, assuming ‘find-image’ is non-monadic, the code above becomes
> something like:
>
> (system-image
> (image (inherit base-image)
> (size image-size)
> (operating-system
> (with-parameters ((%current-target-system "i586-pc-gnu"))
> os))))
I would prefer 'target' to be part of the image itself, as I proposed
here: https://lists.gnu.org/archive/html/guix-devel/2020-05/msg00417.html.
There's no way for now, that the image is built without cross-compiling
for "i586-pc-gnu", so I think it could be part of the "image" record
itself.
WDYT?
>> +(define hurd-in-vm-service-type
>> + (service-type
>> + (name 'hurd-in-vm)
>> + (extensions (list (service-extension shepherd-root-service-type
>> + hurd-in-vm-shepherd-service)))
>> + (default-value (hurd-in-vm-configuration))
>> + (description
>> + "Provide a Virtual Machine running the GNU Hurd.")))
>
> Being pedantic: s|the GNU Hurd|GNU/Hurd|. :-)
>
> Otherwise looks great to me, thank you!
Looks really nice to me too :)
Thanks,
Mathieu
- [bug#41785] [PATCH] DRAFT services: Add 'hurd-in-vm service-type'., (continued)
- [bug#41785] [PATCH] DRAFT services: Add 'hurd-in-vm service-type'., Mathieu Othacehe, 2020/06/12
- [bug#41785] [PATCH] DRAFT services: Add 'hurd-in-vm service-type'., Jan Nieuwenhuizen, 2020/06/12
- [bug#41785] [PATCH v4] services: Add 'hurd-in-vm service-type'., Jan Nieuwenhuizen, 2020/06/14
- [bug#41785] [PATCH v4] services: Add 'hurd-in-vm service-type'., Mathieu Othacehe, 2020/06/14
- [bug#41785] [PATCH v4] services: Add 'hurd-in-vm service-type'., Jan Nieuwenhuizen, 2020/06/14
- [bug#41785] [PATCH v4] services: Add 'hurd-in-vm service-type'., Mathieu Othacehe, 2020/06/14
- [bug#41785] [PATCH v4] services: Add 'hurd-in-vm service-type'., Mathieu Othacehe, 2020/06/14
- bug#41785: [PATCH v4] services: Add 'hurd-in-vm service-type'., Jan Nieuwenhuizen, 2020/06/14
[bug#41785] [PATCH] DRAFT services: Add 'hurd-in-vm service-type'.,
Mathieu Othacehe <=
[bug#41785] [PATCH v3 1/2] image: Make 'find-image' non-monadic., Jan (janneke) Nieuwenhuizen, 2020/06/12
[bug#41785] [PATCH v3 1/2] image: Make 'find-image' non-monadic., Mathieu Othacehe, 2020/06/13