[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#42048: [PATCH 6/6] services: provenance: Save channel introductions.
From: |
Ludovic Courtès |
Subject: |
bug#42048: [PATCH 6/6] services: provenance: Save channel introductions. |
Date: |
Wed, 01 Jul 2020 23:50:21 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi,
Ricardo Wurmus <rekado@elephly.net> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> So yes, I suppose we would need to extend the ‘.guix-channel’ format for
>> dependencies. Luckily it should be quite simply because that format is
>> extensible; older Guix versions would ignore the ‘introduction’ field.
>> It would look something like this:
>>
>> (channel
>> (version 0)
>> (dependencies
>> (channel
>> (name some-collection)
>> (url "https://example.org/first-collection.git")
>> (introduction (channel-introduction
>> (version 0)
>> (commit "…")
>> (signer "…"))))
>> (channel
>> (name some-other-collection)
>> (url "https://example.org/second-collection.git")
>> (branch "testing")))) ;not an authenticated channel
>>
>> It does mean that a channel can indirectly trick you into turning off
>> authentication for a dependent channel. But I think that’s within the
>> expectations for channels: when you choose a channel, you trust it
>> enough to run its code.
>>
>> WDYT?
>
> This sounds reasonable. I agree that you’ve got to trust the channel
> authors anyway, so allowing them to provide the introduction is fair.
I went ahead and did that:
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=d774c7b1218a3cc20079b19812da119f9ed26b54
Let me know what you think!
The whole series is now pushed:
d774c7b121 channels: Dependencies listed in '.guix-channel' can have an
introduction.
884df77640 channels: Properly diagnose test failure.
eb5cf39e66 services: provenance: Save channel introductions.
6d39f0cb77 guix describe: Display channel introductions and add
'channels-sans-intro'.
471550c28c channels: Save and interpret 'introduction' field in provenance
data.
22a9699257 channels: Remove 'signature' from <channel-introduction>.
8b7d982e6a channels: Make channel introductions public.
6577682a6c channels: Add 'openpgp-fingerprint->bytevector'.
Thanks for your feedback,
Ludo’.