[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#42229] [PATCH 8/9] gnu: jami: Fix compilation by providing necessar
From: |
Jan Wielkiewicz |
Subject: |
[bug#42229] [PATCH 8/9] gnu: jami: Fix compilation by providing necessary webchat files. |
Date: |
Tue, 7 Jul 2020 23:22:59 +0200 |
Hello.
On Mon, 06 Jul 2020 22:19:42 +0100
Christopher Baines <mail@cbaines.net> wrote:
> I'd perhaps just say instead that these files are packaged as
> jami-chatview which is used by the jami package, that's probably
> what's useful to know here.
Done.
>
> Because substitute* uses regular expressions, characters like . should
> probably be escaped. However, you might want to try something like the
> following:
>
> (substitute* "CMakeLists.txt"
> (("src/web-chatview/.*") ""))
>
I use to forget this, don't know why. Testing how it works right now.
>
> It would be good if this could be clearer as to what the user gets if
> they install this package. I'm guessing because it's an input to Jami,
> it's probably not useful to have it in your profile?
Users don't have to know this. I made it private by changing
define-public to define.
> Also, if it's going to describe the contents of the package, I'd do it
> in a full sentance, so something like: "This package provides the
> HTML, CSS and JavaScript files for the web chatview for Jami".
Done.
> I think there's some Expat stuff in there too.
Yes, there is, added expat to license list. Shouldn't Jami files
contain explicit license statement though?
>
> Rather than copying, could this be a symlink? That way you're just
> using another store item, rather than copying the files from one to
> another.
Working on this. The build fails on the ".eslintrc.json". Guix for some
reason doesn't like dotfiles.
Jan Wielkiewicz
- [bug#42229] [PATCH 3/9] gnu: jami-apply-dependency-patches, ffmpeg-jami, pjproject-jami: Apply patches from the new libring source., (continued)
- [bug#42229] [PATCH 3/9] gnu: jami-apply-dependency-patches, ffmpeg-jami, pjproject-jami: Apply patches from the new libring source., Jan Wielkiewicz, 2020/07/06
- [bug#42229] [PATCH 2/9] gnu: libringclient: Fetch from git, update to 20200702-guix., Jan Wielkiewicz, 2020/07/06
- [bug#42229] [PATCH 9/9] gnu: pjproject-jami: Fix assertion by disabling debugging., Jan Wielkiewicz, 2020/07/06
- [bug#42229] [PATCH 5/9] gnu: pjproject-jami: Make sure phases are run in order., Jan Wielkiewicz, 2020/07/06
- [bug#42229] [PATCH 6/9] gnu: jami: Add libnm as input., Jan Wielkiewicz, 2020/07/06
- [bug#42229] [PATCH 4/9] gnu: jami: Fetch from git, update to 20200702-guix., Jan Wielkiewicz, 2020/07/06
- [bug#42229] [PATCH 8/9] gnu: jami: Fix compilation by providing necessary webchat files., Jan Wielkiewicz, 2020/07/06
- [bug#42229] [PATCH 8/9] gnu: jami: Fix compilation by providing necessary webchat files., Jan Wielkiewicz, 2020/07/07
[bug#42229] [[PATCH V2] 01/10] gnu: libring: Fetch from git, update to 20200708-guix., Jan Wielkiewicz, 2020/07/10
- [bug#42229] [[PATCH V2] 04/10] gnu: jami: Fetch from git, update to 20200702-guix., Jan Wielkiewicz, 2020/07/10
- [bug#42229] [[PATCH V2] 06/10] gnu: jami: Add libnm as input., Jan Wielkiewicz, 2020/07/10
- [bug#42229] [[PATCH V2] 05/10] gnu: pjproject-jami: Make sure phases are run in order., Jan Wielkiewicz, 2020/07/10
- [bug#42229] [[PATCH V2] 03/10] gnu: jami-apply-dependency-patches, ffmpeg-jami, pjproject-jami: Apply patches from the new libring source., Jan Wielkiewicz, 2020/07/10
- [bug#42229] [[PATCH V2] 02/10] gnu: libringclient: Fetch from git, update to 20200702-guix., Jan Wielkiewicz, 2020/07/10