[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#43064: [PATCH v2] gexp: computed-file: Prevent mistakenly overriding
From: |
Maxim Cournoyer |
Subject: |
bug#43064: [PATCH v2] gexp: computed-file: Prevent mistakenly overriding default option values. |
Date: |
Tue, 01 Sep 2020 09:00:12 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Ludovic Courtès <ludo@gnu.org> writes:
> Hi,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> In order to do so, default to an empty options list, and expose options whose
>> default values are sensitive directly as keyword arguments.
>>
>> * guix/gexp.scm (computed-file): Extract the LOCAL-BUILD? parameter from the
>> OPTIONS parameter to make it a stand-alone keyword argument. Introduce an
>> OPTIONS* binding which is obtained by combining the LOCAL-BUILD? keyword and
>> its value with OPTIONS.
>>
>> Suggested-by: Ludovic Courtès <ludo@gnu.org>
[...]
> Please update doc/guix.texi as well.
>
> Otherwise LGTM, thanks!
>
> Ludo’.
Done!
Thank you,
Maxim
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#43064: [PATCH v2] gexp: computed-file: Prevent mistakenly overriding default option values.,
Maxim Cournoyer <=