[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#42849] [PATCH 3/3] installer: Run the installation inside a contain
From: |
Ludovic Courtès |
Subject: |
[bug#42849] [PATCH 3/3] installer: Run the installation inside a container. |
Date: |
Wed, 02 Sep 2020 22:17:43 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi!
Mathieu Othacehe <othacehe@gnu.org> skribis:
>> So perhaps we can settle on the solution you sent, but let’s see if we
>> can move complexity out of sight. For example, if we can arrange to
>> have a ‘fork+exec-command/container’ procedure that can be passed the
>> PID of a namespace, such that the ‘start’ method of guix-daemon is just
>> a few more lines its current definition, I’ll be happy.
>>
>> How does that sound?
>
> Sounds fine! I added a "fork+exec-command/container" in (gnu build
> shepherd) module, that uses "container-excursion" to enter the
> namespaces of the process passed as argument.
>
> I also took your other remarks into account and pushed this
> serie. Thanks a lot for diving into this harsh stuff :).
Awesome!
> Locally, the installer tests behave fine, but I'll monitor the CI to see
> how it goes.
>
> Now, the only installation test failure I'm aware of is
> https://issues.guix.gnu.org/41948. The good news, is that I have a Guile
> patch that seem to solve it[1].
Yes, it’s still on my radar (started looking into it the other day,
without any tangible result).
Ludo’.