guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#43182] [PATCH 3/3] gnu: nomad: Update to 0.2.0-alpha-100-g6a565d3.


From: Mathieu Othacehe
Subject: [bug#43182] [PATCH 3/3] gnu: nomad: Update to 0.2.0-alpha-100-g6a565d3.
Date: Mon, 07 Sep 2020 08:10:35 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hello Mike,

I pushed the two first ones, thanks.

> * gnu/packages/guile-xyz.scm (nomad): Update to 0.2.0-alpha-100-g6a565d3.

For this one, you need to describe every change exhaustively, according
to the commit message convention. For instance:

[native-inputs]: Add "gettext".
[propagated-inputs]: Move "glib-networking" to ....
[inputs]: ... here.

and so on.

> +                 `("GI_TYPELIB_PATH" ":" prefix (,gi-path ,(getenv 
> "GI_TYPELIB_PATH")))
> +                 `("GIO_EXTRA_MODULES" ":" prefix (,(getenv 
> "GIO_EXTRA_MODULES")))

You can wrap a few lines here to stay under the 78 columns limit.

> +                 `("GST_PLUGIN_SYSTEM_PATH" ":" prefix ,gst-plugins)
> +                 `("NOMAD_WEB_EXTENSION_DIR" ":" prefix (,ext-path)))

If NOMAD_WEB_EXTENSION_DIR is wrapped, it is up to the user to set
it. Don't we want to keep it as a native-search-paths so that any
extension package to nomad is automatically added to this variable?

Thanks,

Mathieu





reply via email to

[Prev in Thread] Current Thread [Next in Thread]