|
From: | Raghav Gururajan |
Subject: | [bug#43348] Profanity |
Date: | Sun, 13 Sep 2020 00:38:02 -0400 |
Hi Danny! > please, for existing packages, try to be as clear as possible in the commit > messages in what is changed (only one related set of things should be changed > per commit). > > In this case the commit confounds things: > > * Changing the build-system reference. This does not enable runtime > features--which is what the commit message's topic stated that the commit > does. > * Changing the autoconf method. This does not enable runtime features--which > is what the commit message's topic stated that the commit does. > * Adding Python as a NATIVE input. What is that about? Is profanity using > a Python program as a compiler only? > * I think that moving those native-inputs to inputs, while correct, does not > enable runtime features--which is what the commit message's topic stated that > the commit does. > * Please use two spaces (after the period) in order to separate sentences. > * Moving blocks around makes review much harder for users. > > The goal of those commit messages, and of the commit rules, is to make it > easy for each user to see at a glance what topic each commit changes. You are correct. I always do these in a hurry, sorry about that. Please find the attached patches. Regards, RG.
0001-gnu-profanity-Make-some-cosmetic-changes.patch
Description: Text Data
0002-gnu-profanity-Move-some-dependencies.patch
Description: Text Data
0003-gnu-profanity-Enable-missing-features.patch
Description: Text Data
0004-gnu-profanity-Change-build-system.patch
Description: Text Data
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] | Current Thread | [Next in Thread] |