guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#43360] [PATCH 1/2] gnu: Add libgda.


From: Ludovic Courtès
Subject: [bug#43360] [PATCH 1/2] gnu: Add libgda.
Date: Tue, 15 Sep 2020 14:30:47 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hi!

Leo Prikler <leo.prikler@student.tugraz.at> skribis:

> * gnu/packages/gnome.scm (libgda): New variable.

[...]

> +         (add-after 'unpack 'remove-broken-tests
> +           (lambda _
> +             (substitute* "tests/multi-threading/Makefile.am"
> +               ((,(string-join
> +                   '("mutex" "parser" "cnc_lock" "threaded_cnc" "wrapper")
> +                   " check_"
> +                   'prefix))

Please use a literal string for the regexp.

It’d also be nice to add a short comment explaining what’s wrong with
those tests.

The rest LGTM, thanks!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]