[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#43722] Add emacs-gcmh package
From: |
Nicolas Goaziou |
Subject: |
[bug#43722] Add emacs-gcmh package |
Date: |
Thu, 01 Oct 2020 14:32:58 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hello,
Niklas Eklund <niklas.eklund@posteo.net> writes:
> * gnu/packages/emacs-xyz.scm (emacs-gcmh): New variable.
Thank you.
Some comments follow.
> +(define-public emacs-gcmh
> + (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
> + (revision "0"))
Could you add a comment explaining why we're providing a specific commit
instead of a tagged release?
> + (package
> + (name "emacs-gcmh")
> + (version (git-version "0.1" revision commit))
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://gitlab.com/koral/gcmh")
> + (commit commit)))
> + (sha256
> + (base32 "1r3wiqhrzh7wvqy484nl031fd4bn4cpvkv9646s4cjgvnnnv7jz3"))
> + (file-name (git-file-name name version))))
> + (build-system emacs-build-system)
> + (home-page "https://gitlab.com/koral/gcmh")
> + (synopsis
> + "The GNU Emacs Garbage Collector Magic Hack")
The string should be moved on the same line as `synopsis'. Also:
Emacs Garbage Collector Magic Hack
is enough.
> + (description
> + "This package enforces a sneaky Garbage Collection strategy to
> minimize
I suggest
... a sneaky @dfn{garbage collector} (GC) strategy to minimize...
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
- [bug#43722] Add emacs-gcmh package,
Nicolas Goaziou <=