[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#44038] [PATCH] Fix deprecation warning for origin-sha256
From: |
Ludovic Courtès |
Subject: |
[bug#44038] [PATCH] Fix deprecation warning for origin-sha256 |
Date: |
Sat, 17 Oct 2020 22:21:45 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi,
Helio Machado <0x2b3bfa0@gmail.com> skribis:
> This patch fixes the following build-time deprecation warning:
>
> guix/import/print.scm:77:21: warning: 'origin-sha256' is deprecated,
> use 'origin-hash' instead
Thanks for looking into it! The deprecation warning is a bit confusing
though in this case because ‘origin-hash’ is not exactly a drop-in
replacement for ‘origin-sha256’, as can be seen in the manual, so this
patch wouldn’t have the desired effect.
Instead, ‘print.scm’ could be changed to emit a (sha256 …) form when the
<content-hash> object is indeed a sha256 hash, and otherwise use a (hash
…) form.
See
<https://guix.gnu.org/manual/devel/en/html_node/origin-Reference.html#index-content_002dhash>.
Thanks,
Ludo’.