[bug#41219] [PATCH 2/2] guix: Enforce package.json "files" directive.

[paul]

Dear Jelle,

On 9/22/20 8:09 PM, Jelle Licht wrote:
> Hey Giacomo,
>
> paul <goodoldpaul@autistici.org> writes:
> > > > +         install-dir)
> > > > +        (begin
> > > > +          (copy-recursively "." install-dir)
> > > > +          ;; Remove references to dependencies
> > > > +          (delete-file-recursively
> > > > +           (string-append install-dir "/node_modules"))))
> > > > +    (if (and main
> > > > +             (not (file-exists?
> > > > +                   (string-append
> > > > +                    install-dir "/" (dirname main)))))
>                                            ^
>
> {New,Forgotten} nitpick; this only checks for the `dirname': why not
> just `(string-append install-dir "/" main)'? Because if
> e.g. "lib/utils.js" is in "files", and main is "lib/main.js", it seems
> that main would not be installed with this snippet. Does that make
> sense?

Yes it definitely does. I believe I fixed this in the attached patch.

Thank you for your review,

Giacomo

0002-guix-Enforce-package.json-files-directive.patch
Description: Text Data