[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#44077] [PATCH 1/2] gnu: Add python-poetry-core.
From: |
Nicolas Goaziou |
Subject: |
[bug#44077] [PATCH 1/2] gnu: Add python-poetry-core. |
Date: |
Tue, 20 Oct 2020 13:51:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hello,
Tanguy Le Carrour <tanguy@bioneland.org> writes:
> * gnu/packages/python-xyz.scm (python-poetry-core): New variable.
Thank you.
> +(define-public python-poetry-core
> + (package
> + (name "python-poetry-core")
> + (version "1.0.0")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "poetry-core" version))
> + (sha256
> + (base32
> + "1mgv276h1iphn5fqhp2sgkgd5d0c39hs33vgaf157x5ri7rlyrka"))))
Nitpick: move the string on the same line as `base32'.
> + (build-system python-build-system)
> + (home-page "https://github.com/python-poetry/poetry-core")
> + (synopsis "Poetry PEP 517 Build Backend")
Nitpick: I would avoid unnecessary capitalization:
Poetry PEP 517 build back-end
> + (description
> + "A PEP 517 build backend implementation developed for Poetry. This
> project
> +is intended to be a light weight, fully compliant, self-contained package
> allowing
> +PEP 517 compatible build frontends to build Poetry managed projects.")
The first sentence should be complete, i.e., with a subject and a verb.
Otherwise, LGTM.
Regards,
--
Nicolas Goaziou
[bug#44077] [PATCH v2 1/2] gnu: Add python-poetry-core., Tanguy Le Carrour, 2020/10/20
[bug#44077] [PATCH v3 1/2] gnu: Add python-poetry-core., Tanguy Le Carrour, 2020/10/22
[bug#44077] [WIP][PATCH 0/2] gnu: poetry: Update to 1.1.3., Tanguy Le Carrour, 2020/10/23
[bug#44077] [PATCH v2 0/7] gnu: poetry: Update to 1.1.4., Tanguy Le Carrour, 2020/10/30
[bug#44077] [PATCH v2 1/7] gnu: python-packaging: Update to 20.4., Tanguy Le Carrour, 2020/10/30