[bug#44274] [PATCH] gnu: Add emacs-powershell.el

[Nicolas Goaziou]

Hello,

Adam Kandur via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-powershell.el): New variable.

Thank you. Some comments follow.

> +(define-public emacs-powershell.el

I suggest to rename it emacs-powershell.

> +  (let ((revision "0")
> +        (commit "d1b3f95669343399f199f291ef76c09a0ede5e60"))
> +    (package
> +      (name "emacs-powershell.el")

See above.

> +      (build-system emacs-build-system)
> +      (arguments
> +       `(#:include '("\\.el$")))
> +      (version "master") ;; tagged branch is outdated (2015)

Version is 0.3 per main Elisp file.

Also, end of line comments start with a single semicolon. Two semicolons
are used only for full line comments. In any case, I suggest to write
the comment above `package' instead.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +            (url "https://github.com/jschaf/powershell.el";)

There seem to be an issue with indentation here.

> +            (commit version)))

This should be (commit commit)

> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "1cxhzaaig88zhylyycvb3849r85j1ijqklnh9zbqsfl2zhpb0g5c"))))
> +      (home-page "https://github.com/jschaf/powershell.el";)
> +      (synopsis "Mode for editing PowerShell scripts")

I suggest:

  Emacs mode for editing PowerShell scripts

> +      (description "@code{powershell.el} Mode is an Emacs major mode for 
> editing and running Microsoft PowerShell files.")

I suggest:

  Powershell is an Emacs major mode…

The library is really named Powershell, and the capitalization makes it
different from PowerShell.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou