[bug#44789] gnu: Add lemonbar-xft.

[elaexuotee]

Christopher Baines <mail@cbaines.net> wrote:
> 
> elaexuotee--- via Guix-patches via <guix-patches@gnu.org> writes:
> 
> > This adds a fork of the `lemonbar' package that supports fontconfig.
> 
> I don't know anything about lemonbar, but this sounds OK in principle.

Thanks for the sanity check.

> So, it would be nice to change the description (and maybe synopsis) to
> set out how this package is different from lemonbar.

Oh cool. I have run across several packages that `inherit` from their parents
without modifying the description, so just kind of blindly followed suit.
Actually, checking package sources however, it looks like inheriting packages
*do* update synopses and descriptions.

> Also, regarding the arguments above, I think you can reduce the
> duplication with the lemonbar package by doing something like:
> 
>   (arguments
>    (substitute-keyword-arguments (package-arguments lemonbar)
>      ((#:make-flags make-flags)
>       (append make-flags
>               (string-append
>                "CFLAGS="
>                (string-join
>                 (list (string-append "-I" (assoc-ref %build-inputs "freetype")
>                                      "/include/freetype2")
>                       (string-append "-D" "VERSION="
>                                      (format #f "'~s'" ,version)))))))))
> 
> I've only just written this in this email, so I'm not sure if it works,
> but I think it's close.

Very nice. It required a tad bit of munging, but was very helpful.

> Would you be able to send an updated patch?

Attached!

Note that I opted to `string-append` to lemonbar's synopsis and description.
This doesn't seem to be common, but does it make sense here?

0001-gnu-Add-lemonbar-xft.patch
Description: Text Data