[bug#45133] Add ocaml reactiveData

[zimoun]

Hi,

On Thu, 10 Dec 2020 at 15:12, divoplade <d@divoplade.fr> wrote:

> The solution was to delete the Makefile just before the install phase

Cool!  That’s what I proposed, sorry if I have not been clear. :-)


> I've tried to reproduce the changes of simon but I'm not sure I
> reproduced the indentation correctly (it's different from what
> etc/indent.el does, but a lot of ocaml packages are not indented
> according to that script).

Ahah!  Let use the one of etc/indent.el for the ocaml-reactivedata and
see the other ones later.


> So the last point is about url-fetch vs git-fetch: why do you want to
> use git-fetch?

Well, because OCaml packages currently uses more git-fetch than url-fetch:

--8<---------------cut here---------------start------------->8---
$ cat gnu/packages/ocaml.scm | grep url-fetch | wc -l
69

$ cat gnu/packages/ocaml.scm | grep git-fetch | wc -l
91
--8<---------------cut here---------------end--------------->8---

It is a matter of taste.  You can read the thread starting here:

<https://yhetil.org/guix-devel/CAJ3okZ0v3VvmT=eWAVeAQoFqZh4L3H4tUkEJn1-5EXcJgRB_tQ@mail.gmail.com>

The main advantages of git-fetch over url-fetch are, IMHO:

 - lint saves to SWH; no SWH fallback with url-fetch
 - easy to try any other commit (--with-commit)
 - with specified commit–as it is here– avoid the in-place upstream replacement 
annoyance

I was just sharing my opinion reading your patch after questions on IRC,
and I have no strong opinions since Julien is the one who will review
and push it. :-)

All the best,
simon