[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#45050] [PATCH] gnu: Update emacs-guix to temporary repository.
From: |
John Soo |
Subject: |
[bug#45050] [PATCH] gnu: Update emacs-guix to temporary repository. |
Date: |
Fri, 11 Dec 2020 12:27:51 -0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hello!
Ludovic Courtès <ludo@gnu.org> writes:
>> * gnu/packages/emacs-xyz.scm (emacs-guix): Update it, [inputs] Use guile for
>> guix.
>
> If it fixes one of the bugs in the tracker, we can mention it in the
> commit log with “Fixes <https://bugs.gnu.org/XYZ>.”
Alright, done.
>> (define-public emacs-guix
>> - (let ((commit "58a840d0671091e3064e36244790ef8839da87d6")
>> - (revision "2"))
>> + (let* ((commit "a694fdbcedb6edd2239a31d326e475c763ee32f8")
>> + (revision "1"))
>
> Please increment the revision number rather than decrement it.
Ah yes, sorry I thought it would be the "revision at commit". I bumped
it to rev 3.
>> (package
>> - (name "emacs-guix")
>> - (version (git-version "0.5.2" revision commit))
>
> Please don’t reindent, the original formatting was fine. :-)
Oh oops, sorry. I think I forgot to reindent after a previous revision.
> I guess it’s fine to use your repo until we hear from Alex Kost.
Hopefully soon :)
Thanks for your review,
John
0001-gnu-Update-emacs-guix.patch
Description: Text Data