guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#45221] [PATCH] guix: qt-build-system: Wrapped executables honor use


From: Zhu Zihao
Subject: [bug#45221] [PATCH] guix: qt-build-system: Wrapped executables honor user's envvars.
Date: Fri, 18 Dec 2020 12:14:44 +0800
User-agent: mu4e 1.4.13; emacs 27.1

Good work! I think this can help solve #45193[1].

And there're still some issues I mentioned in that issues.

1. We may need to fix `wrap-qt-program` in qt-utils.scm. It's
implementation is quite weird(See my reply in [1]). Or we can remove
this function and make package use

  (assoc-ref qt-build-system:%standard-phases 'qt-wrap)

instead.

2. We should search directories in outputs, now we just search all
inputs. Some Qt programs were deployed with a bundle of Qt plugins in
their prefix. If we miss these dirs, they won't run.

[1]: https://issues.guix.gnu.org/45193

--
Retrieve my PGP public key:

  gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F

Zihao

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]